7 Commits

Author SHA1 Message Date
jdl
5ffd50bdea UpsertFunc 2023-12-19 13:59:57 +01:00
jdl
91b2ba30f6 Colleciton.Has convenience function 2023-12-16 21:06:36 +01:00
jdl
c2828592ac Added UpdateFunc for safer updates. 2023-12-06 20:39:08 +01:00
jdl
13e53f0c88 Updated error type 2023-12-05 11:24:03 +01:00
jdl
54c9e89c3e Fixed unwrap method. 2023-12-05 11:16:35 +01:00
jdl
875957f662 Fixed WAL gc age bug 2023-12-05 09:54:41 +01:00
jdl
b251368b09 Cleanup, no logic changes. 2023-12-04 20:25:37 +01:00
6 changed files with 91 additions and 33 deletions

View File

@@ -8,26 +8,27 @@ import (
) )
type Error struct { type Error struct {
msg string Code int64
code int64 Msg string
StackTrace string
collection string collection string
index string index string
stackTrace string
err error // Wrapped error err error // Wrapped error
} }
func NewErr(code int64, msg string) *Error { func NewErr(code int64, msg string) *Error {
return &Error{ return &Error{
msg: msg, Code: code,
code: code, Msg: msg,
} }
} }
func (e *Error) Error() string { func (e *Error) Error() string {
if e.collection != "" || e.index != "" { if e.collection != "" || e.index != "" {
return fmt.Sprintf(`[%d] (%s/%s) %s`, e.code, e.collection, e.index, e.msg) return fmt.Sprintf(`[%d] (%s/%s) %s`, e.Code, e.collection, e.index, e.Msg)
} else { } else {
return fmt.Sprintf("[%d] %s", e.code, e.msg) return fmt.Sprintf("[%d] %s", e.Code, e.Msg)
} }
} }
@@ -36,11 +37,15 @@ func (e *Error) Is(rhs error) bool {
if !ok { if !ok {
return false return false
} }
return e.code == e2.code return e.Code == e2.Code
}
func (e *Error) Unwrap() error {
return e.err
} }
func (e *Error) WithErr(err error) *Error { func (e *Error) WithErr(err error) *Error {
if e2, ok := err.(*Error); ok && e2.code == e.code { if e2, ok := err.(*Error); ok && e2.Code == e.Code {
return e2 return e2
} }
@@ -49,18 +54,11 @@ func (e *Error) WithErr(err error) *Error {
return e2 return e2
} }
func (e *Error) Unwrap() error {
if e.err != nil {
return e.err
}
return e
}
func (e *Error) WithMsg(msg string, args ...any) *Error { func (e *Error) WithMsg(msg string, args ...any) *Error {
err := *e err := *e
err.msg += ": " + fmt.Sprintf(msg, args...) err.Msg += ": " + fmt.Sprintf(msg, args...)
if len(err.stackTrace) == 0 { if len(err.StackTrace) == 0 {
err.stackTrace = string(debug.Stack()) err.StackTrace = string(debug.Stack())
} }
return &err return &err
} }
@@ -78,16 +76,16 @@ func (e *Error) WithIndex(s string) *Error {
} }
func (e *Error) msgTruncacted() string { func (e *Error) msgTruncacted() string {
if len(e.msg) > 255 { if len(e.Msg) > 255 {
return e.msg[:255] return e.Msg[:255]
} }
return e.msg return e.Msg
} }
func (e *Error) Write(w io.Writer) error { func (e *Error) Write(w io.Writer) error {
msg := e.msgTruncacted() msg := e.msgTruncacted()
if err := binary.Write(w, binary.LittleEndian, e.code); err != nil { if err := binary.Write(w, binary.LittleEndian, e.Code); err != nil {
return IO.WithErr(err) return IO.WithErr(err)
} }
@@ -103,7 +101,7 @@ func (e *Error) Read(r io.Reader) error {
size uint8 size uint8
) )
if err := binary.Read(r, binary.LittleEndian, &e.code); err != nil { if err := binary.Read(r, binary.LittleEndian, &e.Code); err != nil {
return IO.WithErr(err) return IO.WithErr(err)
} }
@@ -116,6 +114,6 @@ func (e *Error) Read(r io.Reader) error {
return IO.WithErr(err) return IO.WithErr(err)
} }
e.msg = string(msgBuf) e.Msg = string(msgBuf)
return nil return nil
} }

View File

@@ -10,12 +10,12 @@ func FmtDetails(err error) string {
var s string var s string
if e.collection != "" || e.index != "" { if e.collection != "" || e.index != "" {
s = fmt.Sprintf(`[%d] (%s/%s) %s`, e.code, e.collection, e.index, e.msg) s = fmt.Sprintf(`[%d] (%s/%s) %s`, e.Code, e.collection, e.index, e.Msg)
} else { } else {
s = fmt.Sprintf("[%d] %s", e.code, e.msg) s = fmt.Sprintf("[%d] %s", e.Code, e.Msg)
} }
if len(e.stackTrace) != 0 { if len(e.StackTrace) != 0 {
s += "\n\nStack Trace:\n" + e.stackTrace + "\n" s += "\n\nStack Trace:\n" + e.StackTrace + "\n"
} }
return s return s

View File

@@ -15,7 +15,7 @@ func (rep *Replicator) runWALGC() {
select { select {
case <-ticker.C: case <-ticker.C:
state := rep.getState() state := rep.getState()
before := time.Now().Unix() - rep.conf.WALSegMaxAgeSec before := time.Now().Unix() - rep.conf.WALSegGCAgeSec
if err := rep.wal.DeleteBefore(before, state.SeqNum); err != nil { if err := rep.wal.DeleteBefore(before, state.SeqNum); err != nil {
log.Printf("[WAL-GC] failed to delete wal segments: %v", err) log.Printf("[WAL-GC] failed to delete wal segments: %v", err)
} }

View File

@@ -159,6 +159,15 @@ func (c *Collection[T]) Get(tx *Snapshot, id uint64) *T {
return c.ByID.Get(tx, item) return c.ByID.Get(tx, item)
} }
func (c *Collection[T]) Has(tx *Snapshot, id uint64) bool {
if tx == nil {
tx = c.db.Snapshot()
}
item := new(T)
c.setID(item, id)
return c.ByID.Has(tx, item)
}
func (c *Collection[T]) Insert(tx *Snapshot, userItem *T) error { func (c *Collection[T]) Insert(tx *Snapshot, userItem *T) error {
if tx == nil { if tx == nil {
return c.db.Update(func(tx *Snapshot) error { return c.db.Update(func(tx *Snapshot) error {
@@ -237,6 +246,27 @@ func (c *Collection[T]) update(tx *Snapshot, userItem *T) error {
return nil return nil
} }
func (c *Collection[T]) UpdateFunc(tx *Snapshot, id uint64, update func(item *T) error) error {
if tx == nil {
return c.db.Update(func(tx *Snapshot) error {
return c.updateFunc(tx, id, update)
})
}
return c.updateFunc(tx, id, update)
}
func (c *Collection[T]) updateFunc(tx *Snapshot, id uint64, update func(item *T) error) error {
item := c.Get(tx, id)
if item == nil {
return errs.NotFound
}
if err := update(item); err != nil {
return err
}
c.setID(item, id) // Don't allow the ID to change.
return c.update(tx, item)
}
func (c *Collection[T]) Upsert(tx *Snapshot, item *T) error { func (c *Collection[T]) Upsert(tx *Snapshot, item *T) error {
if tx == nil { if tx == nil {
return c.db.Update(func(tx *Snapshot) error { return c.db.Update(func(tx *Snapshot) error {
@@ -257,6 +287,36 @@ func (c *Collection[T]) upsert(tx *Snapshot, item *T) error {
return err return err
} }
func (c *Collection[T]) UpsertFunc(tx *Snapshot, id uint64, update func(item *T) error) error {
if tx == nil {
c.db.Update(func(tx *Snapshot) error {
return c.upsertFunc(tx, id, update)
})
}
return c.upsertFunc(tx, id, update)
}
func (c *Collection[T]) upsertFunc(tx *Snapshot, id uint64, update func(item *T) error) error {
insert := false
item := c.Get(tx, id)
if item == nil {
item = new(T)
insert = true
}
if err := update(item); err != nil {
return err
}
c.setID(item, id) // Don't allow the ID to change.
if insert {
return c.insert(tx, item)
}
return c.update(tx, item)
}
func (c *Collection[T]) Delete(tx *Snapshot, itemID uint64) error { func (c *Collection[T]) Delete(tx *Snapshot, itemID uint64) error {
if tx == nil { if tx == nil {
return c.db.Update(func(tx *Snapshot) error { return c.db.Update(func(tx *Snapshot) error {

View File

@@ -13,13 +13,13 @@ type Index struct {
} }
func NewIndex(f *File) (*Index, error) { func NewIndex(f *File) (*Index, error) {
maxPage, err := f.maxPage() firstPage, err := f.pageCount()
if err != nil { if err != nil {
return nil, err return nil, err
} }
idx := &Index{ idx := &Index{
fList: newFreeList(maxPage), fList: newFreeList(firstPage),
aList: *newAllocList(), aList: *newAllocList(),
seen: map[[2]uint64]struct{}{}, seen: map[[2]uint64]struct{}{},
mask: []bool{}, mask: []bool{},

View File

@@ -134,7 +134,7 @@ func (pf *File) writePage(page dataPage, id uint64) error {
// Reading // Reading
// ---------------------------------------------------------------------------- // ----------------------------------------------------------------------------
func (pf *File) maxPage() (uint64, error) { func (pf *File) pageCount() (uint64, error) {
fi, err := pf.f.Stat() fi, err := pf.f.Stat()
if err != nil { if err != nil {
return 0, errs.IO.WithErr(err) return 0, errs.IO.WithErr(err)