From 2ef44dbc316139552b03d28f1d9857e819eedbee Mon Sep 17 00:00:00 2001 From: jdl Date: Sun, 14 Jun 2026 20:13:08 +0200 Subject: [PATCH] Audit fixes --- migrate.go | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/migrate.go b/migrate.go index ad0701f..294da70 100644 --- a/migrate.go +++ b/migrate.go @@ -5,8 +5,7 @@ import ( "embed" "errors" "fmt" - "path/filepath" - "sort" + "path" ) const initMigrationTableQuery = ` @@ -34,17 +33,13 @@ func Migrate(db *sql.DB, migrationFS embed.FS) error { return fmt.Errorf("unexpected non-directory in migration FS: %s", dirs[0].Name()) } + // ReadDir returns files in sorted order. dirName := dirs[0].Name() files, err := migrationFS.ReadDir(dirName) if err != nil { return err } - // Sort sql files by name. - sort.Slice(files, func(i, j int) bool { - return files[i].Name() < files[j].Name() - }) - for _, dirEnt := range files { if !dirEnt.Type().IsRegular() { return fmt.Errorf("unexpected non-regular file in migration fs: %s", dirEnt.Name()) @@ -64,7 +59,7 @@ func Migrate(db *sql.DB, migrationFS embed.FS) error { continue } - migration, err := migrationFS.ReadFile(filepath.Join(dirName, name)) + migration, err := migrationFS.ReadFile(path.Join(dirName, name)) if err != nil { return err }