Cleanup - maybe working...

hub/api/api.go

@@ -157,6 +157,16 @@ func (a *API) Peer_Init(peer *Peer, args m.PeerInitArgs) error {
 	a.lock.Lock()
 	defer a.lock.Unlock()
 
+	// Re-read from DB inside the lock — the caller's copy was fetched before
+	// we held the lock, so it may be stale under concurrent requests.
+	current, err := db.Peer_Get(a.db, peer.NetworkID, peer.PeerIP)
+	if err != nil {
+		return err
+	}
+	if len(current.WGPubKey) != 0 {
+		return errors.New("peer already initialized")
+	}
+
 	peer.Version = idgen.NextID(0)
 	peer.WGPubKey = args.WGPubKey
 	peer.SignPubKey = args.SignPubKey

hub/api/migrations/2024-11-30-init.sql

@@ -20,6 +20,6 @@ CREATE TABLE peers (
   Port       INTEGER NOT NULL,
   Relay      INTEGER NOT NULL DEFAULT 0, -- Boolean if peer will forward packets.
   WGPubKey   BLOB    NOT NULL,
-  SignPubKey BLOB    NOT NULL
+  SignPubKey BLOB    NOT NULL,
   PRIMARY KEY(NetworkID, PeerIP)
 ) WITHOUT ROWID;