Audit changes.

peer/new.go

@@ -27,24 +27,35 @@ func New(
 
 	dev, err := wginterface.Open(ifaceName)
 	if err != nil {
+		_ = wginterface.Delete(ifaceName)
 		return nil, fmt.Errorf("open WG device: %w", err)
 	}
 
+	cc, err := newUDPControlConn(state.VPNIP, ControlPort)
+	if err != nil {
+		_ = dev.Close()
+		_ = wginterface.Delete(ifaceName)
+		return nil, fmt.Errorf("control conn: %w", err)
+	}
+
+	cleanup := func() {
+		_ = cc.Close()
+		_ = dev.Close()
+		_ = wginterface.Delete(ifaceName)
+	}
+
 	if err := dev.Configure(state.PrivKey, int(state.WGPort)); err != nil {
+		cleanup()
 		return nil, fmt.Errorf("configure WG device: %w", err)
 	}
 
 	if state.IsRelay {
 		if err := dev.EnableForwarding(); err != nil {
+			cleanup()
 			return nil, fmt.Errorf("enable forwarding: %w", err)
 		}
 	}
 
-	cc, err := newUDPControlConn(state.VPNIP, ControlPort)
-	if err != nil {
-		return nil, fmt.Errorf("control conn: %w", err)
-	}
-
 	pingCh := make(chan PingEvent)
 	hubAddCh := make(chan HubPeer)
 	hubRemoveCh := make(chan wgtypes.Key)
@@ -59,13 +70,15 @@ func New(
 		hubAddCh,
 		hubRemoveCh)
 	if err != nil {
+		cleanup()
 		return nil, fmt.Errorf("hub poller: %w", err)
 	}
 
 	go cc.run(pingCh)
 	go poller.Run()
-	go RunMCWriter(state.VPNIP, state.PrivKey.PublicKey(), state.WGPort, &state.SignKey)
+
 	if !state.IsPublic {
+		go RunMCWriter(state.VPNIP, state.PrivKey.PublicKey(), state.WGPort, &state.SignKey)
 		go RunMCReader(state.VPNNet, state.VPNIP, multicastCh)
 	}