Audit changes

hub/api/api.go

@@ -169,11 +169,25 @@ func (a *API) sweepSessions() {
 }
 
 func (a *API) Network_Create(n *Network) error {
+	a.lock.Lock()
+	defer a.lock.Unlock()
+
 	n.NetworkID = idgen.NextID(0)
 	return errs.DB(db.Network_Insert(a.db, n))
 }
 
 func (a *API) Network_Delete(n *Network) error {
+	a.lock.Lock()
+	defer a.lock.Unlock()
+
+	exists, err := db.Network_HasPeers(a.db, n.NetworkID)
+	if err != nil {
+		return errs.DB(err)
+	}
+	if exists {
+		return errs.Conflict.WithMsg("Delete all peers before deleting network.")
+	}
+
 	return errs.DB(db.Network_Delete(a.db, n.NetworkID))
 }
 
@@ -189,6 +203,9 @@ func (a *API) Network_List() ([]*Network, error) {
 }
 
 func (a *API) Peer_CreateNew(p *Peer) error {
+	a.lock.Lock()
+	defer a.lock.Unlock()
+
 	p.WGPubKey = []byte{}
 	p.SignPubKey = []byte{}
 	p.APIKey = idgen.NewToken()
@@ -217,6 +234,9 @@ func (a *API) Peer_Init(peer *Peer, args m.PeerInitArgs) error {
 }
 
 func (a *API) Peer_Delete(networkID int64, peerIP byte) error {
+	a.lock.Lock()
+	defer a.lock.Unlock()
+
 	return errs.DB(db.Peer_Delete(a.db, networkID, peerIP))
 }
 

hub/api/db/written.go

@@ -1,5 +1,7 @@
 package db
 
+import "database/sql"
+
 func Peer_ListAll(tx TX, networkID int64) ([]*Peer, error) {
 	const query = Peer_SelectQuery + ` WHERE NetworkID=? ORDER BY PeerIP ASC`
 	return Peer_List(tx, query, networkID)
@@ -11,3 +13,9 @@ func Peer_GetByAPIKey(tx TX, apiKey string) (*Peer, error) {
 		Peer_SelectQuery+` WHERE APIKey=?`,
 		apiKey)
 }
+
+func Network_HasPeers(db *sql.DB, networkID int64) (exists bool, err error) {
+	const query = "SELECT EXISTS(SELECT 1 FROM peers WHERE NetworkID=?)"
+	err = db.QueryRow(query, networkID).Scan(&exists)
+	return exists, err
+}