From 1d318b4ae7c7cf5d8f0abcd8c7558df2b00e26be Mon Sep 17 00:00:00 2001 From: jdl Date: Sat, 1 Mar 2025 17:29:43 +0100 Subject: [PATCH] cleanup --- peer/controlmessage.go | 16 ++++++++-------- peer/state-client.go | 2 +- peer/util_test.go | 7 ------- 3 files changed, 9 insertions(+), 16 deletions(-) diff --git a/peer/controlmessage.go b/peer/controlmessage.go index 75a94d0..f327291 100644 --- a/peer/controlmessage.go +++ b/peer/controlmessage.go @@ -16,6 +16,14 @@ type controlMsg[T any] struct { func parseControlMsg(srcIP byte, srcAddr netip.AddrPort, buf []byte) (any, error) { switch buf[0] { + case packetTypeInit: + packet, err := parsePacketInit(buf) + return controlMsg[packetInit]{ + SrcIP: srcIP, + SrcAddr: srcAddr, + Packet: packet, + }, err + case packetTypeSyn: packet, err := parsePacketSyn(buf) return controlMsg[packetSyn]{ @@ -40,14 +48,6 @@ func parseControlMsg(srcIP byte, srcAddr netip.AddrPort, buf []byte) (any, error Packet: packet, }, err - case packetTypeInit: - packet, err := parsePacketInit(buf) - return controlMsg[packetInit]{ - SrcIP: srcIP, - SrcAddr: srcAddr, - Packet: packet, - }, err - default: return nil, errUnknownPacketType } diff --git a/peer/state-client.go b/peer/state-client.go index 49e4375..7e9d7c9 100644 --- a/peer/state-client.go +++ b/peer/state-client.go @@ -128,7 +128,7 @@ func (s *stateClient) onProbe(msg controlMsg[packetProbe]) peerState { s.syn.TraceID = newTraceID() s.syn.Direct = true s.Send(s.staged, s.syn) - s.logf("Successful probe.") + s.logf("Successful probe to %v.", sent.Addr) return s } diff --git a/peer/util_test.go b/peer/util_test.go index 128d29a..af05365 100644 --- a/peer/util_test.go +++ b/peer/util_test.go @@ -9,13 +9,6 @@ func addrPort4(a, b, c, d byte, port uint16) netip.AddrPort { return netip.AddrPortFrom(netip.AddrFrom4([4]byte{a, b, c, d}), port) } -func assertNil(t *testing.T, err error) { - t.Helper() - if err != nil { - t.Fatal(err) - } -} - func assertType[T any](t *testing.T, obj any) T { t.Helper() x, ok := obj.(T)